Skip to content

Rollup of 2 pull requests #119343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 27, 2023
Merged

Rollup of 2 pull requests #119343

merged 5 commits into from
Dec 27, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

veera-sivarajan and others added 5 commits December 20, 2023 20:50
@veera-sivarajan
fix: diagnostic for casting reference to slice
e6e195e 
fixes: rust-lang#118790
@veera-sivarajan
Update existing tests
286f2d8
@mu001999
Remove dead codes
3386783
@matthiaskrgr
Rollup merge of rust-lang#119175 - veera-sivarajan:fix-cast-to-slice,…
d6382c7 
… r=WaffleLapkin

fix: diagnostic for casting reference to slice

fixes:  rust-lang#118790

Removes `if self.cast_ty.is_trait()` to produce the same diagnostic for cast to slice and trait.
@matthiaskrgr
Rollup merge of rust-lang#119337 - mu001999:dead_code/clean, r=Waffle…
f05e16a 
…Lapkin

Remove dead codes

Detected by rust-lang#118257
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 27, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=2

@bors
Copy link
Collaborator

bors commented Dec 27, 2023

📌 Commit f05e16a has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2023
@bors
Copy link
Collaborator

bors commented Dec 27, 2023

⌛ Testing commit f05e16a with merge df5d535...

@bors
Copy link
Collaborator

bors commented Dec 27, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing df5d535 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 27, 2023
@bors bors merged commit df5d535 into rust-lang:master Dec 27, 2023
@rustbot rustbot added this to the 1.77.0 milestone Dec 27, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#119175 fix: diagnostic for casting reference to slice b21d0e56e05f165b5ced17a2b826fbc959a857a8 (link)
#119337 Remove dead codes b47270f835c4d6ee6bc8e25a27354ee45100c03a (link)

previous master: 9da44323c9

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (df5d535): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.7% [0.7%, 0.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 -3.2% [-3.4%, -3.0%] 2
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.712s -> 672.752s (0.30%)
Artifact size: 312.42 MiB -> 312.42 MiB (-0.00%)

@matthiaskrgr matthiaskrgr deleted the rollup-vkt8lst branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @bors @rust-timer @rustbot @veera-sivarajan @mu001999